Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hairline gap between notification banner header and outer border on high resolution screens in Chrome/Edge (Blink) #2035

Merged
merged 2 commits into from
Nov 25, 2020
Merged

Fix hairline gap between notification banner header and outer border on high resolution screens in Chrome/Edge (Blink) #2035

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd497c6
Invert notification banner header / content colouring to fix gap on l…
andymantell Nov 25, 2020
06c155a
Changelog entry for notification banner fix on high res screens (fd49…
andymantell Nov 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions src/govuk/components/notification-banner/_index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@

border: $govuk-border-width solid $govuk-brand-colour;

background-color: $govuk-brand-colour;

&:focus {
outline: $govuk-focus-width solid $govuk-focus-colour;
}
Expand All @@ -16,8 +18,6 @@
// Ensures the notification header appears separate to the notification body text in high contrast mode
border-bottom: 1px solid transparent;

background-color: $govuk-brand-colour;

@include govuk-media-query($from: tablet) {
padding: 2px govuk-spacing(4) govuk-spacing(1);
}
Expand All @@ -34,10 +34,16 @@
}

.govuk-notification-banner__content {
margin: govuk-spacing(3);
padding: govuk-spacing(3);

background-color: $govuk-body-background-colour;

@include govuk-media-query($from: tablet) {
margin: govuk-spacing(4);
padding: govuk-spacing(4);
}

> :last-child {
margin-bottom: 0;
}
}

Expand All @@ -57,9 +63,7 @@
.govuk-notification-banner--success {
border-color: $govuk-success-colour;

.govuk-notification-banner__header {
background-color: $govuk-success-colour;
}
background-color: $govuk-success-colour;

.govuk-notification-banner__link {
@include govuk-link-style-success;
Expand Down