Remove tabindex attribute from notification alert banner on blur #2014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is following some feedback from the GDS Accessibility clinic: #1999 (comment) There is no need for the component to be focusable after the page has loaded. Only remove the tabindex attribute if it was set by JavaScript.
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-2014
36degrees
reviewed
Nov 12, 2020
src/govuk/components/notification-banner/notification-banner.test.js
Outdated
Show resolved
Hide resolved
This was referenced Nov 12, 2020
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-2014
36degrees
approved these changes
Nov 16, 2020
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-2014
Also test that if the tabindex wasn't added with JavaScript, it doesn't get removed by the script.
hannalaakso
force-pushed
the
notification-banner-remove-tabindex-on-blur
branch
from
345f919 to
f7e9b8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need for the notification banner component to remain focusable after the page has loaded and the focus has moved away from it. This is following some feedback from the GDS Accessibility clinic: #1999 (comment).
This PR:
Partially addresses #2011