Fix character count shrinking as you go over limit #1912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The character count still compensates for the error state having a thicker border, by reducing the padding by 2px when the `--error` modifier is applied. Since we removed the thicker border from the error state In 6bdca06, this now 'over-compensates', causing the padding on the character count's textarea to shrink by 2px when the user goes over the character limit. Remove the padding override on the `--error` modifier as it's no longer needed.
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1912
vanitabarrett
approved these changes
Aug 13, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The character count still compensates for the error state having a thicker border, by reducing the padding by 2px when the
--errormodifier is applied.Since we removed the thicker border from the error state In 6bdca06, this now 'over-compensates', causing the padding on the character count's textarea to shrink by 2px when the user goes over the character limit.
Remove the padding override on the
--errormodifier as it's no longer needed.👉🏻 Preview
Fixes #1910