Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import textarea from character count #1765

Merged
merged 2 commits into from
Mar 25, 2020
Merged

Conversation

36degrees
Copy link
Contributor

The character count component wraps the textarea component, but does not currently import it.

This means that, for example, if you only @import govuk/components/character-count the textarea would be unstyled.

Import the textarea component so that the styles are included correctly.

The character count component wraps the textarea component, but does not currently import it.

This means that, for example, if you only `@import govuk/components/character-count` the textarea would be unstyled.

Import the textarea component so that the styles are included correctly.
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1765 March 16, 2020 10:26 Inactive
Copy link
Contributor

@NickColley NickColley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, nice 👍

@36degrees 36degrees merged commit 415a3de into master Mar 25, 2020
@36degrees 36degrees deleted the character-count-import-textarea branch March 25, 2020 09:56
@36degrees 36degrees added this to the Next milestone Mar 25, 2020
@36degrees 36degrees mentioned this pull request Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants