Ensure components use public govuk-media-query mixin
#1655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We wrap the media query (mq) library with `govuk-media-query` so we can change it in the future. I think these may have been missed out when we originally did that work: #763 There is no impact on users that I'm aware of, so this is just a tidy up.
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1655
NickColley
changed the title
govuk-media-query mixin
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1655
NickColley
force-pushed
the
fix-use-of-private-mixin-in-components
branch
from
1424cd3
to
c336a53
Compare
36degrees
approved these changes
Nov 20, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We wrap the media query (mq) library with
govuk-media-queryso we can change it in the future.I think these may have been missed out when we originally did that work:
#763
There is no impact on users that I'm aware of, so this is just a tidy up.
Closes #1654