Explicitly set font weight on warning-text component #1585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly set the font-weight of the warning text component, and move the font styles to the __text element (the __icon element has its own size, weight and colour) Warning text is otherwise only bold because of the user-agent styling of <strong> elements. When used with GOV.UK Elements, which includes a reset stylesheet, the font-weight is reset to normal, which means the warning text is currently set in a normal weight.
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1585
NickColley
approved these changes
Sep 23, 2019
36degrees
changed the title
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly set the font-weight of the warning text component, and move the font styles to the
__textelement (the__iconelement has its own size, weight and colour)Warning text is otherwise only bold because of the user-agent styling of
<strong>elements. When used with GOV.UK Elements, which includes a reset stylesheet, thefont-weightis reset tonormal, which means the warning text is currently set in a normal weight.Before
Legacy mode OFF
Legacy mode ON
After
Legacy mode OFF
Legacy mode ON