Removing font style adjustments #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1441
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1441
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1441
NickColley
approved these changes
Jun 10, 2019
There was a problem hiding this comment.
The header in legacy mode seems quite a lot bigger, is this intentional?
Apart from that I've looked at the before and after with legacy mode and it all looks good to me.
Would be good to get @dashouse 's sign off.
| left: 0; | ||
|
|
||
| margin: auto; | ||
| } | ||
| } | ||
|
|
||
| // Begin adjustments for font baseline offset | ||
| // These should be removed when the font is updated with the correct baseline | ||
| @if $govuk-use-legacy-font { |
There was a problem hiding this comment.
I like using this instead of compatibility mode, feels more explicit 👍
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1441
|
Looks good to me 👏 |
NickColley
reviewed
Jun 11, 2019
| padding-left: 8px; | ||
| } @else { | ||
| @include govuk-font($size: 16, $weight: bold, $line-height: 1); | ||
| padding-top: 5px; |
There was a problem hiding this comment.
Non-blocking this could be short hand as a one liner.
NickColley
approved these changes
Jun 11, 2019
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1441
aliuk2012
force-pushed
the
al/font-adjustments
branch
from
672cf78
to
6a42186
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1441
aliuk2012
force-pushed
the
al/font-adjustments
branch
from
6a42186
to
bcf65db
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off @dashouse initial spike #1356 and linked to #1434.
This PR moves the adjustments behind a sass variable called
$govuk-use-legacy-font. This should mean that services not running in compatibility mode should have a slightly smaller compiled CSS without the adjustments.Components checked
Components affected and updated