Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes tabs keyboard navigation bug in IE8 #1359

Merged
merged 3 commits into from
May 20, 2019
Merged

fixes tabs keyboard navigation bug in IE8 #1359

merged 3 commits into from
May 20, 2019

Commits on May 20, 2019

  1. fixes tabs keyboard navigation bug in IE8 

    In IE8, the browser could not find the next/previous tab because it does
not support `nextElementSibling` and `previousElementSibling` DOM traversal
methods. To fix it I applied a polyfill for it.

Once the browser could find the tab we then had to find the `firstChildElement`
(i.e the anchor element) to add/edit the various data attributes to show/hide
the tab panel. Again IE8 doesn't support it and instead of introducing another
polyfill I used `querySelector instead to look up the "a". I assumed the
first element would always be anchor for navigation purposes and also the
nunjucks template uses an anchor with the class name that I'm looking up.
    @aliuk2012
    aliuk2012 committed May 20, 2019
    Configuration menu
    Copy the full SHA
    d8cf5e5 View commit details
    Browse the repository at this point in the history

  2. Add two polyfills for nextElementSibling and previousElementSibling 

    I've added two new files polyfill files although they didn't come directly
from polyfill.io they were based off a PR that was merged in the library
but not included in the new polyfill-library repo.
I've added comments pointing to the original pull request for the
detection and for the polyfill.
    @aliuk2012
    aliuk2012 committed May 20, 2019
    Configuration menu
    Copy the full SHA
    4997c72 View commit details
    Browse the repository at this point in the history

  3. adds CHANGELOG entry

    @aliuk2012
    aliuk2012 committed May 20, 2019
    Configuration menu
    Copy the full SHA
    9e1c25f View commit details
    Browse the repository at this point in the history