Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger setAttributes on all radio inputs #1163

Conversation

frankieroberto
Copy link
Contributor

This enables the conditional reveals to work where two different macros are used with the same name attribute (eg to enable grouping of radio inputs).

One possible fix for #1079.

This enables the conditional reveals to work where two different macros are used with the same name attribute (eg to enable grouping of radio inputs).
@kr8n3r
Copy link

kr8n3r commented Feb 4, 2019

@frankieroberto /src/components/radios/radios.js:49:49: Block must not be padded by blank lines.

@frankieroberto
Copy link
Contributor Author

@igloosi fixed, thanks.

@NickColley NickColley added the awaiting triage Needs triaging by team label Feb 6, 2019
@NickColley
Copy link
Contributor

Hey Frankie,

Thanks for the suggestion.

I think we need to fix this in a way that doesn't look for inputs on the document, as that's created bugs in the past.

We're going to see what @colinrotherham has found out from his research and consider a fix based on that.

Are you OK for me to close this based on that?

@NickColley NickColley removed the awaiting triage Needs triaging by team label Feb 13, 2019
@frankieroberto
Copy link
Contributor Author

@NickColley can you explain what the issues are? Maybe there's a way to avoid them?

I did consider whether the event could be triggered on only the radio inputs which shared the same name attribute, but that was a bigger refactor, and triggering it on all radio buttons didn't seem to have any side-effects.

@NickColley
Copy link
Contributor

You can see this bug: #1156

Let me know if you have any ideas. 👍

@NickColley NickColley added the awaiting triage Needs triaging by team label Mar 4, 2019
@kellylee-gds kellylee-gds added Priority: Low and removed awaiting triage Needs triaging by team labels Mar 6, 2019
@NickColley
Copy link
Contributor

I've spoken to @frankieroberto and since this is not blocking him immediately anymore we're going to close this and action the corresponding issue when we have time #1079.

Thanks @frankieroberto for helping us figure this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants