-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trigger setAttributes on all radio inputs #1163
Trigger setAttributes on all radio inputs #1163
Conversation
This enables the conditional reveals to work where two different macros are used with the same name attribute (eg to enable grouping of radio inputs).
@frankieroberto |
@igloosi fixed, thanks. |
Hey Frankie, Thanks for the suggestion. I think we need to fix this in a way that doesn't look for inputs on the document, as that's created bugs in the past. We're going to see what @colinrotherham has found out from his research and consider a fix based on that. Are you OK for me to close this based on that? |
@NickColley can you explain what the issues are? Maybe there's a way to avoid them? I did consider whether the event could be triggered on only the radio inputs which shared the same |
You can see this bug: #1156 Let me know if you have any ideas. 👍 |
I've spoken to @frankieroberto and since this is not blocking him immediately anymore we're going to close this and action the corresponding issue when we have time #1079. Thanks @frankieroberto for helping us figure this out. |
This enables the conditional reveals to work where two different macros are used with the same name attribute (eg to enable grouping of radio inputs).
One possible fix for #1079.