Enable autocomplete attributes for input components
#1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WCAG 2.1 introduces a new success criteria "1.3.5 Identify Input Purpose" which "is to ensure that the purpose of a form input collecting information about the user can be programmatically determined, so that user agents can extract and present this purpose to users using different modalities". Broadly speaking, we can help service teams meet this criteria by making it easier to pass autocomplete attributes to components. At the minute this can be done by using the attributes option, but making it part of the component API promotes the idea that this should be used when it makes sense to do so.
WCAG 2.1 introduces a new success criteria "1.3.5 Identify Input Purpose" which "is to ensure that the purpose of a form input collecting information about the user can be programmatically determined, so that user agents can extract and present this purpose to users using different modalities". Broadly speaking, we can help service teams meet this criteria by making it easier to pass autocomplete attributes to components. At the minute this can be done by using the attributes option, but making it part of the component API promotes the idea that this should be used when it makes sense to do so.
WCAG 2.1 introduces a new success criteria "1.3.5 Identify Input Purpose" which "is to ensure that the purpose of a form input collecting information about the user can be programmatically determined, so that user agents can extract and present this purpose to users using different modalities". Broadly speaking, we can help service teams meet this criteria by making it easier to pass autocomplete attributes to components. At the minute this can be done by using the attributes option, but making it part of the component API promotes the idea that this should be used when it makes sense to do so.
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1146
NickColley
approved these changes
Jan 16, 2019
There was a problem hiding this comment.
Looks really good to me! 🚀
I don't think we necessarily need the review application examples since we can test this fine with the unit tests but It's no harm for them to be there (potentially we'll want to test autofill behaviour in the future?)
I think you need a changelog entry.
| }) | ||
|
|
||
| const $firstItems = $('.govuk-date-input__item:first-child input') | ||
| expect($firstItems.attr('autocomplete')).toEqual('bday-day') |
There was a problem hiding this comment.
Non-blocking: I wonder if we should assert that all three are there...
There was a problem hiding this comment.
Thanks Nick 👍 Going to leave it as it is for now to keep things consistent, there's about 10 tests in this file that follow the same pattern. Maybe it's something we can look at separately.
hannalaakso
force-pushed
the
enable-autocomplete-on-components
branch
from
8f8dca0 to
601f592
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set textarea, input and date input components to accept
autocompleteoption and add tests to ensure the attribute gets rendered.This helps to surface the new WCAG 2.1 guidelines for "Identify Input Purpose" - see #1136
There's also a card to document this in the Design System.
Fixes #1136
Edit: The initial PR also updated the character count to do this. This change was subsequently removed as it appears that of the autofill attributes, only
street-addresscan be multiline and character count wouldn't be used in this scenario.