update template.njk to add IE meta tag #1119
Merged
+8
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickColley
approved these changes
Jan 9, 2019
CHANGELOG.md
Outdated
| @@ -22,11 +22,11 @@ | |||
|
|
|||
| 🔧 Fixes: | |||
|
|
|||
| - Pull Request Title goes here | |||
| - update template.njk to add IE meta tag | |||
There was a problem hiding this comment.
Thanks for picking this up so quickly, it looks really good. I have one small note about the CHANGELOG entry:
We try to keep the template in the CHANGELOG for future people to copy and paste, so maybe we could update this to be:
Suggested change
| - update template.njk to add IE meta tag | |
| - Pull Request Title goes here | |
| Description goes here (optional) | |
| ([PR #N](https://github.com/alphagov/govuk-frontend/pull/N)) | |
| - Improve rendering in older Internet Explorer |
That said if you want us to do this on your behalf let me know and I'll get this merged in.
There was a problem hiding this comment.
Thanks, @NickColley for the help. I have made the necessary changes. Please review.
To ensure that older IE versions always render with the correct rendering engine, added a meta tag
NickColley
approved these changes
Jan 10, 2019
aliuk2012
approved these changes
Jan 10, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure that older IE versions always render with the correct rendering engine, added a meta tag