Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Header full width with navigation" example text slightly bunched up #891

Closed
hannalaakso opened this issue Jul 13, 2018 · 1 comment
Closed

"Header full width with navigation" example text slightly bunched up #891

hannalaakso opened this issue Jul 13, 2018 · 1 comment

Comments

@hannalaakso
Copy link
Member

The "Product name" in the example ends up nearly touching the "Menu" text. We should probably add a bit of margin to to the menu button so that it's clearly separate from the service name.

Screen grab from Samsung Galaxy S8 (Chrome and Samsung Internet):

screen shot 2018-07-13 at 09 53 50
@kr8n3r kr8n3r mentioned this issue Sep 21, 2018
Merged
kr8n3r pushed a commit that referenced this issue Sep 21, 2018
Add spacing for more space
f94c727 
As noted in #891 at certain viewport, the space between menu and product
name is very tight.

This adds a bit more space between both.
kr8n3r pushed a commit that referenced this issue Sep 25, 2018
Add spacing for more space
dc143dd 
As noted in #891 at certain viewport, the space between menu and product
name is very tight.

This adds a bit more space between both.
kr8n3r pushed a commit that referenced this issue Sep 26, 2018
Add spacing for more space
33b8df2 
As noted in #891 at certain viewport, the space between menu and product
name is very tight.

This adds a bit more space between both.
kr8n3r pushed a commit that referenced this issue Oct 2, 2018
Add spacing for more space
df413cf 
As noted in #891 at certain viewport, the space between menu and product
name is very tight.

This adds a bit more space between both.
@kr8n3r
Copy link

kr8n3r commented Oct 3, 2018

fixed by #1007

@kr8n3r kr8n3r closed this as completed Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@NickColley @kr8n3r @hannalaakso