Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated govuk-grid-row mixin #1092

Closed
36degrees opened this issue Dec 13, 2018 · 0 comments
Closed

Remove deprecated govuk-grid-row mixin #1092

36degrees opened this issue Dec 13, 2018 · 0 comments
Labels
breaking change
Milestone
v3.0.0

Comments

@36degrees
Copy link
Contributor

In #1090 we moved the rules from the govuk-grid-row mixin and used them to create a concrete .govuk-grid-row class.

We retained the existing govuk-grid-row mixin to avoid a breaking change, but should remove it in the next breaking release (v3.0).
@36degrees 36degrees added this to the v3.0.0 milestone Dec 13, 2018
aliuk2012 added a commit that referenced this issue May 14, 2019
@aliuk2012
removes deprecated govuk-grid-row mixin
3472066 
#1090 copied govuk-grid-row
mixin to create a new concrete `.govuk-grid-row` class and marked the mixin as deprecated.

ACTION TO BE TAKEN: Remove any references to `govuk-grid-row` mixin and
                    use `.govuk-grid-row` class.

closes: #1092
@aliuk2012 aliuk2012 mentioned this issue May 14, 2019
Merged
aliuk2012 added a commit that referenced this issue Jun 14, 2019
@aliuk2012
removes deprecated govuk-grid-row mixin
480cf3b 
#1090 copied govuk-grid-row
mixin to create a new concrete `.govuk-grid-row` class and marked the mixin as deprecated.

ACTION TO BE TAKEN: Remove any references to `govuk-grid-row` mixin and
                    use `.govuk-grid-row` class.

closes: #1092
aliuk2012 added a commit that referenced this issue Jun 14, 2019
@aliuk2012
removes deprecated govuk-grid-row mixin
f24aab1 
#1090 copied govuk-grid-row
mixin to create a new concrete `.govuk-grid-row` class and marked the mixin as deprecated.

ACTION TO BE TAKEN: Remove any references to `govuk-grid-row` mixin and
                    use `.govuk-grid-row` class.

closes: #1092
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change
Projects
GOV.UK Design System cycle board
Archived in project
Milestone
v3.0.0
Development

No branches or pull requests
2 participants
@36degrees @aliuk2012