Skip to content

Commit

Permalink
Printing style for current page
Browse files Browse the repository at this point in the history
Changing the blue back to the brand colour `#1d70b8` when printing.  The colour `#1d8feb` is presumably to contrast against the black `#0b0c0c` header, but when printing the header is white, so it makes sense to use a darker blue which contrasts better against white.

Linting tests changes

Removed trailing spaces and added blank line as per linting test errors

Linting tests changes

Removed blank line as per linting test errors (yep - the same one that the linter told me to add)

Remove whitespace

Update changelog with link to PR

undid mistake
  • Loading branch information
MalcolmVonMoJ authored and owenatgov committed Dec 5, 2022
1 parent e75c10f commit bb7c449
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
### Fixes

- [#2998: Refactor back link and breadcrumb chevrons to use ems](https://github.com/alphagov/govuk-frontend/pull/2998)
- [#3021 Printing style for current page link in header](https://github.com/alphagov/govuk-frontend/pull/3021) - thanks to [Malcolm Butler](https://github.com/MalcolmVonMoJ) for the contribution

## 4.4.0 (Feature release)

Expand Down
6 changes: 6 additions & 0 deletions src/govuk/components/header/_index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,12 @@
color: $govuk-header-link-active;
}

// When printing, use the normal blue as this contrasts better with the
// white printing header
@include govuk-media-query($media-type: print) {
color: $govuk-brand-colour;
}

// When focussed, the text colour needs to be darker to ensure that colour
// contrast is still acceptable
&:focus {
Expand Down

0 comments on commit bb7c449

Please sign in to comment.