Merge pull request #1676 from alphagov/fix-skip-link-losing-underline…

…-on-focus Fix skip link component focus style with global styles enabled
alphagov · Dec 12, 2019 · 933c9cd · 933c9cd
2 parents cfca85f + 9b84259
commit 933c9cd
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -12,6 +12,7 @@ If you're using Nunjucks, you can now add classes to the character count compone
 
 ### Fixes
 
+- [Pull request #1676: Fix skip link component focus style with global styles enabled](https://github.com/alphagov/govuk-frontend/pull/1676).
 - [Pull request #1670: Make width-container margins more targetted to avoid specificity issues](https://github.com/alphagov/govuk-frontend/pull/1670).
 - [Pull request #1655: Ensure components use public `govuk-media-query` mixin](https://github.com/alphagov/govuk-frontend/pull/1655).
 - [Pull request #1638: Check component item arrays are not empty before outputting markup](https://github.com/alphagov/govuk-frontend/pull/1638).

diff --git a/src/govuk/components/skip-link/_skip-link.scss b/src/govuk/components/skip-link/_skip-link.scss
@@ -26,6 +26,12 @@
     &:focus {
       outline: $govuk-focus-width solid $govuk-focus-colour;
       background-color: $govuk-focus-colour;
+
+      // Undo unwanted changes when global styles are enabled
+      @if ($govuk-global-styles) {
+        box-shadow: none;
+        text-decoration: underline;
+      }
     }
   }
 }