Preview v5: Update application paths for govuk-frontend@5
#336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for govuk-frontend-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
colinrotherham
force-pushed
the
v5-github-actions
branch
from
e402571
to
3e9eed3
Compare
colinrotherham
force-pushed
the
v5-package-resolution
branch
from
8c49706
to
5f66c52
Compare
colinrotherham
force-pushed
the
v5-package-resolution
branch
from
5f66c52
to
b4f799b
Compare
36degrees
reviewed
Aug 1, 2023
| @@ -337,14 +337,14 @@ class Test | |||
| }) | |||
| url = @helper.github_url(fixture) | |||
|
|
|||
| expect(url).to eq("https://github.com/alphagov/govuk-frontend/tree/v1.0.0/src/govuk/helpers/_clearfix.scss#L9-L15") | |||
| expect(url).to eq("https://github.com/alphagov/govuk-frontend/tree/v5.0.0/packages/govuk-frontend/src/govuk/helpers/_clearfix.scss#L9-L15") | |||
There was a problem hiding this comment.
Can we add another test for the other part of the ternary?
So expect that when package starts with 4 it returns the old path structure?
There was a problem hiding this comment.
Yeah, would you mind lending a hand?
I'm guessing my way through Ruby
There was a problem hiding this comment.
✅ Updated with help from @romaricpascal
colinrotherham
force-pushed
the
v5-package-resolution
branch
2 times, most recently
from
fc6b28c
to
9dc0847
Compare
colinrotherham
force-pushed
the
release/5.0
branch
from
1feafbc
to
acfaaf9
Compare
Co-authored-by: Romaric Pascal <romaric.pascal@digital.cabinet-office.gov.uk>
colinrotherham
force-pushed
the
v5-package-resolution
branch
from
9dc0847
to
6dfd665
Compare
romaricpascal
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the GitHub URL helper for GOV.UK Frontend v5
For now, I've maintained backwards compatibility with v4