Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preview v5: GitHub Actions fixes #335

Merged
merged 3 commits into from
Aug 1, 2023
Merged

Preview v5: GitHub Actions fixes #335

merged 3 commits into from
Aug 1, 2023

Conversation

colinrotherham
Copy link
Contributor

This PR includes a couple of GitHub Actions fixes:

  1. The npm script check-links can fail silently
  2. The checks are duplicates across pull and pull_request events

Broken image

Matching the GOV.UK Design System check-links arguments found a --skip argument typo

We have a broken image that should skipped with property="og:url" property="og:image"

@colinrotherham colinrotherham requested a review from a team as a code owner July 28, 2023 08:45
@netlify
Copy link

netlify bot commented Jul 28, 2023 •
edited
Loading

✅ Deploy Preview for govuk-frontend-docs-preview ready!

Name Link
🔨 Latest commit 3e9eed3
🔍 Latest deploy log https://app.netlify.com/sites/govuk-frontend-docs-preview/deploys/64c8ae9ed28af6000821e5c1
😎 Deploy Preview https://deploy-preview-335--govuk-frontend-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@romaricpascal romaricpascal mentioned this pull request Jul 28, 2023
Closed
@36degrees 36degrees added this to the v5.0.0 milestone Jul 31, 2023
@romaricpascal romaricpascal mentioned this pull request Jul 31, 2023
Closed
@36degrees
Copy link
Contributor

Is it possible to elaborate on the commit message for 62a3c2a? I don't really understand why it was broken, nor why the changes fix it.

Otherwise the changes look good to me.

@colinrotherham
Copy link
Contributor Author

colinrotherham commented Jul 31, 2023 •
edited
Loading

Is it possible to elaborate on the commit message for 62a3c2a? I don't really understand why it was broken, nor why the changes fix it.

@36degrees Same here!

We had the same on the Design System repo though

Lots of Check links successful output but with a non-zero exit code from tap-spot:

Swapping to tap-mocha-reporter spots the property="og:url" property="og:image" typo

I'll take a look tomorrow as this branch has 7x stacked PRs on top of it 🙈

@colinrotherham
Fix link checker reporting
3e3adb6 
We often see sucessful log output from `tap-spot` followed by a non-zero error code so we’ve swapped it for `tap-mocha-reporter` like we did on GOV.UK Design System

I’ve also added the `--canonicalroot` flag to check more internal assets that would have previously been skipped as external

Note: We still have a broken share image

* alphagov/tech-docs-gem#194
@colinrotherham
Allow manual GitHub Actions “Test” runs
b5fcae0
@colinrotherham
Prevent GitHub Actions “Test” duplicate runs on push
3e9eed3
@colinrotherham
Copy link
Contributor Author

@36degrees I've added an overview to the commit message, thanks again

@colinrotherham
Copy link
Contributor Author

Thanks @36degrees

We'll keep an eye on it

Like on GOV.UK Design System it'll probably still fail sometimes

@colinrotherham colinrotherham merged commit db0a91f into release/5.0 Aug 1, 2023
5 checks passed
@colinrotherham colinrotherham deleted the v5-github-actions branch August 1, 2023 09:39
@colinrotherham colinrotherham mentioned this pull request Aug 2, 2023
Merged
@36degrees 36degrees mentioned this pull request Aug 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@36degrees 36degrees 36degrees approved these changes

Assignees
No one assigned
Labels
None yet
Projects
GOV.UK Design System cycle board
Archived in project
Milestone
v5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@colinrotherham @36degrees