Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Exit This Page JavaScript API documentation #331

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

querkmachine
Copy link
Member

Adds parameter documentation to the JavaScript API Reference for the Exit This Page component that shipped in GOV.UK Frontend 4.7.0.

Resolves #330.

Additionally, fixes two (probable?) discrepancies in formatting in other docs:

  • NotificationBanner → disableAutoFocus parameter header was written in backticks.
  • Accordion → i18n → showAllSections was written namespaced and at a higher heading level than other headers.

@querkmachine querkmachine requested review from claireashworth and a team July 20, 2023 10:51
@querkmachine querkmachine self-assigned this Jul 20, 2023
@netlify
Copy link

netlify bot commented Jul 20, 2023

Deploy Preview for govuk-frontend-docs-preview ready!

Name Link
🔨 Latest commit 085e19e
🔍 Latest deploy log https://app.netlify.com/sites/govuk-frontend-docs-preview/deploys/64b94bca0d7d2f0008634c42
😎 Deploy Preview https://deploy-preview-331--govuk-frontend-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@36degrees 36degrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

Good spot on the other formatting issues too! 👀

@querkmachine querkmachine force-pushed the add-exit-this-page-js-api-docs branch from 1d42ea8 to 085e19e Compare July 20, 2023 14:59
@querkmachine querkmachine merged commit 94698da into main Jul 20, 2023
6 checks passed
@querkmachine querkmachine deleted the add-exit-this-page-js-api-docs branch July 20, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add JS API docs for ExitThisPage class
3 participants