Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set rps limit to 10 for bank-holidays.json rate limiter #132

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Set rps limit to 10 for bank-holidays.json rate limiter #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33ac657
Set rps limit to 10 for bank-holidays.json rate limiter
samsimpson1 Feb 3, 2025
d855d16
Use client.ip instead of req.http.Fastly-Client-IP for bank holidays …
samsimpson1 Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dictionaries.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@ bankholidaystest_percentages:
B: 1
# Dictionary for /bank-holidays.json rate limiter
bankholidaysjson_ratelimiter:
/bank-holidays.json: 'Bank Holidays JSON'
'/bank-holidays.json': 'Bank Holidays JSON'
4 changes: 2 additions & 2 deletions www/service.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,13 +143,13 @@ resource "fastly_service_vcl" "service" {
rate_limiter {
name = "rate_limiter_bank_holidays_json"

rps_limit = 5
rps_limit = 10
window_size = 10
penalty_box_duration = 1

uri_dictionary_name = "bankholidaysjson_ratelimiter"

client_key = "req.http.Fastly-Client-IP"
client_key = "client.ip"
http_methods = "GET,PUT,TRACE,POST,HEAD,DELETE,PATCH,OPTIONS"

action = "response"
Expand Down
Loading