Replace legacy GPG usage with Secrets Manager. #4482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's time we got rid of our dreadfully insecure use of GPG for shared secrets (and in general). - Add a playbook entry for retrieving a shared credential from Secrets Manager (with a subtle warning about the evils of allowing such things to exist in the first place). - Replace links to the govuk-secrets pass store with references to Secrets Manager. - Secure and simplify a clunky procedure for rotating Fastly API tokens which the Emergency Alerts feature apparently uses to purge objects from the CDN cache. - Remove all references to GPG, including a page about using it to transfer files (yowch!) which I suspect some poor soul added in a valiant but doomed attempt to handle that whacky API token request the first time around (vide supra). This unblocks deleting the security dumpster-inferno that is the govuk-secrets repo.
sengi
force-pushed
the
sengi/die-gpg-die
branch
from
547f351 to
fb1372a
Compare
|
Rebase to fix merge conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get rid of our sketchy use of GPG.
This unblocks deleting the security dumpster-inferno that is the govuk-secrets repo.
Background
It's 2024. Even 5-10 years ago, infosec professionals were blogging about how problematic GPG is (though some folks still like using it for email 🤷). Our usage of it has always been pretty iffy, so let's make the most of the opportunity to get rid of it while we can.