-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check answers and extended grid #692
Conversation
This needs a |
3a4cb49
to
3406ee5
Compare
You can preview this change here: Built with commit 827270c https://deploy-preview-692--govuk-design-system-preview.netlify.com |
Totally non-blocking, and I'm aware this is how it was in the existing pattern, but the more I look at it the stranger I find it it is that there are entries for both 'Contact information' and 'Contact details'… Surely that's just two different ways of saying the same thing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks really good – nice one @dashouse None of my comments are blocking and all relate to things which haven't been introduced by this PR, but:
That's all from me. Thanks |
3406ee5
to
827270c
Compare
This PR adds:
A coded example of the 'Check answers' pattern using the 'Summary list' component and the desktop specific grid.
Documents the extended grid on the layout page (needs a review / chat with @amyhupe)