Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow recursion in macro options #667

Merged
merged 10 commits into from
Dec 18, 2018
Merged

Conversation

NickColley
Copy link
Contributor

@NickColley NickColley commented Dec 12, 2018

In order to allow for nested options in the new Summary list component we need to recursively work through the options.

This also changes existing components so that they consistently output additional tables for hidden components such as 'hint' and 'label'

https://deploy-preview-667--govuk-design-system-preview.netlify.com/components/radios/#options-example-default--label

screen shot 2018-12-18 at 15 30 05

@NickColley NickColley changed the title Allow recursion in macro options WIP: Allow recursion in macro options Dec 12, 2018
@govuk-design-system-ci
Copy link
Collaborator

govuk-design-system-ci commented Dec 12, 2018

You can preview this change here:

Built with commit 75bb992

https://deploy-preview-667--govuk-design-system-preview.netlify.com

@NickColley NickColley force-pushed the allow-recursion-in-macro-options branch from e676dc7 to 75bb992 Compare December 18, 2018 15:12
@NickColley NickColley changed the title WIP: Allow recursion in macro options Allow recursion in macro options Dec 18, 2018
Copy link
Contributor

@36degrees 36degrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @NickColley 👌

@NickColley NickColley merged commit 81f13f9 into master Dec 18, 2018
@36degrees 36degrees deleted the allow-recursion-in-macro-options branch December 19, 2018 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants