-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow recursion in macro options #667
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's difficult to know why the options were being updated, now the code is executed in the a way that you'd expect variables to be already populated.
NickColley
changed the title
Allow recursion in macro options
WIP: Allow recursion in macro options
Dec 12, 2018
You can preview this change here: Built with commit 75bb992 https://deploy-preview-667--govuk-design-system-preview.netlify.com |
This was referenced Dec 17, 2018
NickColley
force-pushed
the
allow-recursion-in-macro-options
branch
from
December 18, 2018 15:12
e676dc7
to
75bb992
Compare
NickColley
changed the title
WIP: Allow recursion in macro options
Allow recursion in macro options
Dec 18, 2018
36degrees
approved these changes
Dec 18, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @NickColley 👌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to allow for nested options in the new Summary list component we need to recursively work through the options.
This also changes existing components so that they consistently output additional tables for hidden components such as 'hint' and 'label'
https://deploy-preview-667--govuk-design-system-preview.netlify.com/components/radios/#options-example-default--label