Bump marked from 15.0.3 to 15.0.4 in the metalsmith group #4376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
✅ You can preview this change here:
To edit notification comments on pull requests, go to your Netlify site configuration. |
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/metalsmith-4dde962128
branch
from
0804510 to
5a8598f
Compare
Bumps the metalsmith group with 1 update: [marked](https://github.com/markedjs/marked). Updates `marked` from 15.0.3 to 15.0.4 - [Release notes](https://github.com/markedjs/marked/releases) - [Changelog](https://github.com/markedjs/marked/blob/master/.releaserc.json) - [Commits](markedjs/marked@v15.0.3...v15.0.4) --- updated-dependencies: - dependency-name: marked dependency-type: direct:development update-type: version-update:semver-patch dependency-group: metalsmith ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/metalsmith-4dde962128
branch
from
5a8598f to
b0aeaa2
Compare
Flakiness in the search tests is caused by some kind of timing/race condition with the .type() method not completing before we assert our expectations. Adding a delay to the text input seems to make it less flaky, but I've moved into a separate function to make it easier to iterate fixes if further flakiness occurs. I've tried sending characters individually, setting focus on each character, and using page.waitForFunction, but this seems to be the least flaky fix.
|
Note: in case of future flakiness. I've attempted what I would assume was the "correct" way to handle this: async function typeText($element, text, page) {
await $element.focus()
await $element.type(text)
await page.waitForFunction(
(input, typedText) => input.value === typedText,
{},
$element,
text
)
}and it's still flaky. Investigating one or two other things, but it might be worth merging this just to get this fix in. |
romaricpascal
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Would be great to have a more sturdy option than a timeout to fix the flakiness, but given the complexity, let's use the delay and create a separate task to investigate why there's some timing issue between the typing and us reading stuff on the page.
Thanks for the fix and the thorough look into this @domoscargin 🙌🏻 ⛵
domoscargin
deleted the
dependabot/npm_and_yarn/metalsmith-4dde962128
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps the metalsmith group with 1 update: marked.
Updates
markedfrom 15.0.3 to 15.0.4Release notes
Sourced from marked's releases.
Commits
dba1327chore(release): 15.0.4 [skip ci]e4198edfix: fix list with no items looping forever (#3560)10020d0chore(deps-dev): Bump eslint from 9.14.0 to 9.16.0 (#3556)f9948c1chore(deps-dev): Bump@markedjs/eslint-configfrom 1.0.8 to 1.0.9 (#3555)9f247c2chore(deps-dev): Bump@arethetypeswrong/clifrom 0.17.0 to 0.17.1 (#3554)107ccfechore(deps-dev): Bump rollup from 4.27.4 to 4.28.1 (#3553)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions