Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix format inconsistencies #416

Merged
merged 1 commit into from
Jun 29, 2018
Merged

Fix format inconsistencies #416

merged 1 commit into from
Jun 29, 2018

Conversation

alex-ju
Copy link
Contributor

@alex-ju alex-ju commented Jun 29, 2018 •
edited
Loading

  1. Nunjucks code is formatted consistently using straight double quotes:
{% from "macro.njk" import function %}

{{ function({
  attribute: "value"
}) }}

Exceptions:

  • when having straight double quotes inside the string: e.g. html: '<a href="#">'
  • when having a boolean value
  1. The published guidance is formatted consistently using opening/closing single and double quotes instead of straight single and double quotes.

This PR along with alphagov/govuk-frontend#830 are fixing alphagov/govuk-frontend#756

Trello card

@govuk-design-system-ci
Copy link
Collaborator

You can preview this change here:

Built with commit 04335aa

https://deploy-preview-416--govuk-design-system-preview.netlify.com

kr8n3r
kr8n3r approved these changes Jun 29, 2018
View reviewed changes
Copy link
Contributor

@kr8n3r kr8n3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ace! doing the boring job so we don't have to

@alex-ju alex-ju merged commit 6d05b81 into master Jun 29, 2018
@alex-ju alex-ju deleted the fix-format-inconsistencies branch June 29, 2018 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kr8n3r kr8n3r kr8n3r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alex-ju @govuk-design-system-ci @kr8n3r