-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPIKE] Add parent prefixes to nested component options #2892
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinrotherham
added
the
documentation
User requests new documentation or improvements to existing documentation
label
Jul 3, 2023
✅ You can preview this change here:
To edit notification comments on pull requests, go to your Netlify site configuration. |
colinrotherham
force-pushed
the
nested-option-formatting
branch
2 times, most recently
from
July 3, 2023 12:55
ccda791
to
7b5958e
Compare
colinrotherham
commented
Jul 3, 2023
colinrotherham
force-pushed
the
nested-option-formatting
branch
from
July 3, 2023 13:45
7b5958e
to
553d5a1
Compare
colinrotherham
changed the title
Use parent prefixes for nested component options
[SPIKE] Add parent prefixes to nested component options
Jul 6, 2023
colinrotherham
force-pushed
the
nested-option-formatting
branch
2 times, most recently
from
July 7, 2023 15:36
67daac3
to
ed9d090
Compare
This was referenced Jul 7, 2023
not a priority but needs team decision |
colinrotherham
added
design
website
Issues relating to the Design System website itself
labels
Aug 3, 2023
colinrotherham
force-pushed
the
nested-option-formatting
branch
2 times, most recently
from
August 7, 2023 20:54
87711bd
to
244244d
Compare
colinrotherham
force-pushed
the
option-table-types
branch
2 times, most recently
from
August 14, 2023 08:22
d6587ee
to
9c05f9f
Compare
colinrotherham
force-pushed
the
nested-option-formatting
branch
from
August 14, 2023 08:22
244244d
to
089195c
Compare
colinrotherham
force-pushed
the
option-table-types
branch
from
August 15, 2023 15:18
9c05f9f
to
e8482d5
Compare
colinrotherham
force-pushed
the
nested-option-formatting
branch
from
August 15, 2023 15:21
089195c
to
024f259
Compare
colinrotherham
force-pushed
the
option-table-types
branch
5 times, most recently
from
August 29, 2023 16:56
04ca24e
to
d6559fe
Compare
colinrotherham
force-pushed
the
nested-option-formatting
branch
from
August 29, 2023 16:58
024f259
to
782a5d6
Compare
colinrotherham
force-pushed
the
option-table-types
branch
from
August 30, 2023 20:24
d6559fe
to
9004604
Compare
colinrotherham
force-pushed
the
nested-option-formatting
branch
from
August 30, 2023 20:31
782a5d6
to
adf836b
Compare
colinrotherham
force-pushed
the
option-table-types
branch
from
September 18, 2023 11:10
9004604
to
ed4fc6b
Compare
colinrotherham
force-pushed
the
nested-option-formatting
branch
from
September 18, 2023 11:28
adf836b
to
096ec9f
Compare
@colinrotherham Please can you confirm whether this needs design or dev review? |
@stevenjmesser Both please Out of the series of Macro options spikes this was the most extreme, so no problem saying "let's close it" |
colinrotherham
force-pushed
the
option-table-types
branch
2 times, most recently
from
September 28, 2023 08:35
112d29c
to
552f606
Compare
colinrotherham
force-pushed
the
nested-option-formatting
branch
from
September 28, 2023 08:36
096ec9f
to
8d16ab8
Compare
colinrotherham
force-pushed
the
option-table-types
branch
from
September 28, 2023 08:56
552f606
to
1d2aa44
Compare
colinrotherham
force-pushed
the
nested-option-formatting
branch
from
September 28, 2023 08:57
8d16ab8
to
4becbde
Compare
colinrotherham
force-pushed
the
option-table-types
branch
from
September 28, 2023 09:02
1d2aa44
to
810c8fa
Compare
colinrotherham
force-pushed
the
nested-option-formatting
branch
from
September 28, 2023 09:03
4becbde
to
330b8e6
Compare
colinrotherham
force-pushed
the
nested-option-formatting
branch
from
October 11, 2023 15:03
330b8e6
to
c5a5238
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
design
documentation
User requests new documentation or improvements to existing documentation
website
Issues relating to the Design System website itself
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Morning 👋
I noticed last week that we sometimes "dot-prefix" nested option names with the associated parent or component:
Nested options with prefixes
For example Accordion
summary.text
andsummary.html
are NOT shown as nested options. Perhaps for readability, does the prefix visually help the nested option link together with the parent it belongs to?Nested options without prefixes
But there are many more examples where we don't benefit from "dot-prefix" clarity in our docs, should we add them?
For example the nested
hint
option in the image below. It's easy to lose context, especially whenhtml
andtext
options and descriptions are frequently duplicated elsewhere on examples pagesFor comparison, here's (hopefully) a complete list of all the options we don't "dot-prefix":
Character count
formGroup.classes
label.text
label.html
label.for
label.isPageHeading
label.classes
label.attributes
hint.text
hint.html
hint.id
hint.classes
hint.attributes
Checkboxes
conditional.html
formGroup.classes
label.text
label.html
label.for
label.isPageHeading
label.classes
label.attributes
hint.text
hint.html
hint.id
hint.classes
hint.attributes
Date input
formGroup.classes
hint.text
hint.html
hint.id
hint.classes
hint.attributes
File upload
formGroup.classes
Input
suffix.text
suffix.html
suffix.classes
suffix.attributes
formGroup.classes
label.text
label.html
label.for
label.isPageHeading
label.classes
label.attributes
hint.text
hint.html
hint.id
hint.classes
hint.attributes
Radios
conditional.html
formGroup.classes
label.text
label.html
label.for
label.isPageHeading
label.classes
label.attributes
hint.text
hint.html
hint.id
hint.classes
hint.attributes
Select
formGroup.classes
label.text
label.html
label.for
label.isPageHeading
label.classes
label.attributes
hint.text
hint.html
hint.id
hint.classes
hint.attributes
Textarea
formGroup.classes
label.text
label.html
label.for
label.isPageHeading
label.classes
label.attributes
hint.text
hint.html
hint.id
hint.classes
hint.attributes
Summary list
title.text
title.html
title.headingLevel
title.classes
Task list
card.title
card.actions
card.classes
title.text
title.html
title.headingLevel
title.classes
Nested options with automatic prefixes
This spike PR updates nested options to add parent prefixes automatically