Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Replace metalsmith-tagcleaner with a custom marked renderer" #2288

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

36degrees
Copy link
Contributor

Reverts #2276

This has introduced some unexpected changes – notably where there is no whitespace between a paragraph and a list, the list items are not made into a list but instead end up part of the paragraph.

For example:

Remember, you must: - tell users about the cookies your service sets on their device - let users accept or reject any cookies that are not essential to providing your service

We think this might have been introduced by the update to Marked, as v4.0.15 includes a change that sounds highly related, but just reinstalling the earlier versions of marked and jstransformer-marked doesn't appear to resolve the issue.

There's a Gist of the differences caused by this change here: https://gist.github.com/36degrees/61bccc9f64a35252f6911c3bf377cac5

@36degrees 36degrees requested a review from domoscargin August 1, 2022 16:27
@netlify
Copy link

netlify bot commented Aug 1, 2022

You can preview this change here:

Name Link
🔨 Latest commit ef86cdc
🔍 Latest deploy log https://app.netlify.com/sites/govuk-design-system-preview/deploys/62e7fed71ffa630008f02b92
😎 Deploy Preview https://deploy-preview-2288--govuk-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@36degrees 36degrees merged commit 4e015a2 into main Aug 1, 2022
@36degrees 36degrees deleted the revert-2276-bk-spike-tagcleaner-replacement branch August 1, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants