Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to more up to date link for Ethnicity harmonised standard #2285

Merged
merged 2 commits into from
Aug 2, 2022

Conversation

edwardhorsford
Copy link
Contributor

GSS appear to have moved to a new site - the link was pointing at the old (and out of date) archived standard.

See #2284 for more relevant conversation.

GSS appear to have moved to a new site - the link was pointing at the old (and out of date) archived standard.
@netlify
Copy link

netlify bot commented Jul 29, 2022

You can preview this change here:

Built without sensitive environment variables

Name Link
🔨 Latest commit 3b97070
🔍 Latest deploy log https://app.netlify.com/sites/govuk-design-system-preview/deploys/62e8eed0d04ee80008023188
😎 Deploy Preview https://deploy-preview-2285--govuk-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@36degrees
Copy link
Contributor

@edwardhorsford if this was merged would it resolve #2284?

@edwardhorsford
Copy link
Contributor Author

@edwardhorsford if this was merged would it resolve #2284?

No it wouldn't. The pattern is still using the harmonised standard from 2011, where GSS now recommends teams may want to use the Census questions instead.

However, in linking to the correct version of the standard, teams may at least see the published notes about the standard being revised and how it relates to the 2021 Census.

@domoscargin
Copy link
Contributor

Thanks, @edwardhorsford!

Should this link be to the overview at https://analysisfunction.civilservice.gov.uk/government-statistical-service-and-statistician-group/gss-support/gss-harmonisation-support/harmonised-standards-and-guidance/?

Since this pattern covers:

  • age
  • disability
  • ethnic group
  • marital or partnership status
  • religion
  • sex and gender identity
  • sexual orientation

@calvin-lau-sig7 calvin-lau-sig7 self-requested a review August 2, 2022 09:10
Co-authored-by: Calvin Lau <77630796+calvin-lau-sig7@users.noreply.github.com>
@edwardhorsford
Copy link
Contributor Author

Thanks @domoscargin and @calvin-lau-sig7 - yeah I had the wrong link. Now fixed with @calvin-lau-sig7's suggestion.

Copy link
Contributor

@domoscargin domoscargin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Just need another review from the team before merging.

Edit: No we don't! Thanks @calvin-lau-sig7

@domoscargin domoscargin merged commit 04acf9d into alphagov:main Aug 2, 2022
@edwardhorsford edwardhorsford deleted the patch-2 branch August 2, 2022 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

4 participants