Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metalsmith dependencies and use core plugins #2263

Merged
merged 6 commits into from
Jul 27, 2022

Conversation

domoscargin
Copy link
Contributor

What

This replaces some of our metalsmith dependencies with their new "core" versions, which are maintained by the metalsmith team and more up to date. It also updates plugins which are still maintained. It does not address any dependencies that don't have a direct, switchable successor:

plugin might be replaced by core?
metalsmith-assets metalsmith-include-files no
metalsmith-broken-link-checker metalsmith-link-checker no
metalsmith-browser-sync
metalsmith-canonical
metalsmith-fingerprint-ignore
metalsmith-rollup
metalsmith-tagcleaner our own plugin?

It also doesn't address the update of packages which have been blocked by metalsmith issues in the past (#1663)

Changelogs are in the commit messages. After each package update, I ran npm build and npm test before moving to the next, and didn't encounter any obvious issues.

Why

Metalsmith has recently stepped up active development, and this allows us to keep these dependencies up to date. It's an interim step before we revisit the use of metalsmith as our static site generator (#2023)

- Allow storing the environment variables under a metadata[metadatakey] instead of metadata. See opts.metadatakey for more details.
- Dependency updates
Core metalsmith plugin is effectively an updated version of the previous package.

v4.5.0

- feat: org migration, core plugin alignment
- feat: use metalsmith.match instead of multimatch, drop Node < 10 support
- feat: better jsdoc typehints & defaults mgmt
- fix: don't mistake dots in folder paths for extensions
The core plugin replaces the old one.

v2.5.1
- pass the transformed list of files to metalsmith.match…
- Merge pull request #184 from doteco/master
- pass the transformed list of files to metalsmith.match so that renamed files can be matched

v2.5.0

- use metalsmith.match instead of multimatch
- Remove semicolons, run formatting. Remove devDependencies
- feat: add JSdocs, named plugin function
- Dependencies: updates debug to 4.3.4
- Drop Node < 12 support

2.4.0

- Return when done
- Improve readme
- Align dotfiles, repo with core plugin setup @metalsmith
- deps: update dependencies and fix prefer-object-spread
@netlify
Copy link

netlify bot commented Jul 21, 2022

You can preview this change here:

Name Link
🔨 Latest commit 11e400c
🔍 Latest deploy log https://app.netlify.com/sites/govuk-design-system-preview/deploys/62d9bac417120400089b3b40
😎 Deploy Preview https://deploy-preview-2263--govuk-design-system-preview.netlify.app/community/design-system-working-group
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@36degrees 36degrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, thanks @domoscargin 👍🏻

@domoscargin domoscargin merged commit 867a531 into main Jul 27, 2022
@domoscargin domoscargin deleted the bk-bump-metalsmith-deps branch July 27, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants