Add info on default components in page template #2173
Conversation
✅ You can preview this change here:
To edit notification comments on pull requests, go to your Netlify site settings. |
EoinShaughnessy
force-pushed
the
iterate-pagetemplate-skiplink-header-footer
branch
from
a3132d6 to
1390779
Compare
|
@36degrees Can I get a review? :) |
|
Catching up with @EoinShaughnessy tomorrow to talk through the page template guidance as I think there's some overlap with some of the existing content that needs resolving. |
EoinShaughnessy
force-pushed
the
iterate-pagetemplate-skiplink-header-footer
branch
from
8ebd1aa to
4ff2e12
Compare
EoinShaughnessy
force-pushed
the
iterate-pagetemplate-skiplink-header-footer
branch
from
1f2e758 to
dd8b71a
Compare
EoinShaughnessy
force-pushed
the
iterate-pagetemplate-skiplink-header-footer
branch
from
d3c7b36 to
0642b7f
Compare
| @@ -13,6 +13,8 @@ The footer provides copyright, licensing and other information about your servic | |||
|
|
|||
| {{ example({group: "components", item: "footer", example: "default", id: "default-1", html: true, nunjucks: true, open: false, size: "m"}) }} | |||
|
|
|||
| If you use the page template, you'll also get the footer without having to add it, as it's included by default. However, if you want to customise the default footer, read the [page template guidance about customising components](/styles/page-template/#changing-template-content). | |||
There was a problem hiding this comment.
I think a lot of people come straight into the "components" section and might not know where to go to get the Page Template info (my instinct was "patterns", not "styles").
I wonder if people will read the first part of this and gloss over the second part because of the "however", and thus not be able to find the page template guidance.
I might be overthinking, and looking through the comments, it looks like this has been discussed already.
|
I think this looks OK from a dev perspective. Just a minor comment. Looks fine to merge before starting on #2203. |
Fixes #2162.
Updates these guidance pages:
Reason for update
The footer, header and skip link guidance pages do not tell users that the page template includes these components by default. This might have led some users to think they had no option but to add the components themselves.
We're also updating the page template guidance to explain how users can customise these components. However, our hope is that users will stick with the template once they're aware it exists.