-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add placeholder text info to text input guidance #2152
Conversation
✅ You can preview this change here:
To edit notification comments on pull requests, go to your Netlify site settings. |
May I suggest a rearrangement and rewording, something like:
|
@davidc-gds @edwardhorsford @jbuller Thanks for your comments and suggestions! I've added a commit that tries to combine your feedback. |
ac98c1d
to
a9684ab
Compare
254a454
to
708cf71
Compare
I'm sure you're delighted to get this over the line at last and I'm so pleased to have contributed too :) |
@jbuller Thanks for your help! We've now added a heading for placeholder text. |
Fixes #2149.
Updates our text input guidance to give more detail on why users should not use placeholder text.