Use ESM modules from GOV.UK Frontend #2146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ You can preview this change here:
To edit notification comments on pull requests, go to your Netlify site settings. |
vanitabarrett
added
javascript
vanitabarrett
force-pushed
the
use-esm
branch
2 times, most recently
from
3d8656b to
874dc19
Compare
4 tasks
domoscargin
reviewed
Apr 25, 2022
| @@ -1,10 +1,8 @@ | |||
| import common from 'govuk-frontend/govuk/common' | |||
| import { nodeListForEach } from './components/helpers.js' | |||
domoscargin
reviewed
Apr 25, 2022
| // Find first skip link module to enhance. | ||
| var $skipLink = document.querySelector('[data-module="govuk-skip-link"]') | ||
| new SkipLink($skipLink).init() | ||
| import { initAll } from 'govuk-frontend' |
|
I've rebased this to get rid of the pre-release commit, so I think this can be merged once the tests pass. |
added 2 commits
May 18, 2022 13:18
The GOV.UK Frontend ES modules don't make the common (e.g: `nodeListForEach`) function available to import. We've made this decision intentionally as we never really intended for `nodeListForEach` to be something we provided. This introduces a helper.js file which contains `nodeListForEach`. Switch our JS files to use that helper, rather than the one from GOV.UK Frontend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update the Design System website to use the GOV.UK Frontend ES modules when they're published (added in alphagov/govuk-frontend#711 )
Why
We don't do any custom initialising of component JavaScript any more, so we can replace the code in
govuk-frontend.jswith an import andinitAll()Note: this PR is based on a pre-release, and will need to be updated/that commit removed before merging