Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fieldset to align with the new address fields #2128

Merged
merged 2 commits into from
Apr 11, 2022
Merged

Conversation

Ciandelle
Copy link
Contributor

Just updated the address pattern and noticed that the fieldset was still using the older version.

@netlify
Copy link

netlify bot commented Apr 8, 2022

You can preview this change here:

Name Link
🔨 Latest commit dca2a42
🔍 Latest deploy log https://app.netlify.com/sites/govuk-design-system-preview/deploys/6253ecc73a3da10008bbc226
😎 Deploy Preview https://deploy-preview-2128--govuk-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Ciandelle Ciandelle self-assigned this Apr 8, 2022
Copy link
Member

@christopherthomasdesign christopherthomasdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of small changes to the macro we should probs do

src/components/fieldset/address-group/index.njk Outdated Show resolved Hide resolved
src/components/fieldset/address-group/index.njk Outdated Show resolved Hide resolved
@Ciandelle Ciandelle merged commit 14cf5a9 into main Apr 11, 2022
@Ciandelle Ciandelle deleted the fieldset-address branch April 11, 2022 15:37
@Ciandelle Ciandelle restored the fieldset-address branch April 12, 2022 14:16
@36degrees 36degrees deleted the fieldset-address branch June 27, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

3 participants