Add guidance for divider and "none of these" to Checkboxes component #1535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ You can preview this change here: 🔨 Explore the source changes: bb69762 🔍 Inspect the deploy log: https://app.netlify.com/sites/govuk-design-system-preview/deploys/60d461cba3803500075b003b 😎 Browse the preview: https://deploy-preview-1535--govuk-design-system-preview.netlify.app |
|
@calvin-lau-sig7 one other thing, I wasn't sure where best to place the error message guidance for the None option. One the one hand, it probably makes sense for it to be alongside the other error message guidance (which is where I put it), but on the other, it does make referring to it within the section a bit clumsy. I did have "(see below)" initially, but that felt worse... 🤔
|
frankieroberto
changed the title
frankieroberto
changed the title
36degrees
force-pushed
the
add-divider-and-none-of-thse
branch
from
022fe1a
to
337429c
Compare
frankieroberto
force-pushed
the
add-divider-and-none-of-thse
branch
from
337429c
to
ac602c3
Compare
36degrees
changed the title
calvin-lau-sig7
approved these changes
Jun 21, 2021
…e Checkboxes component.
lfdebrux
force-pushed
the
add-divider-and-none-of-thse
branch
from
f56715f
to
bb69762
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the GOV.UK Design System website with guidance on the use of a "None of these" option for the Checkboxes component.
➡️ Preview of the Checkboxes component with new guidance
Uses a pre-release version of
govuk-frontend, currently open as PR #2151.NOTE: Do not merge until the
govuk-frontendPR has been merged and released, and then update this PR to use the released version.