Image attachments #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attachments can be embedded using `[embed:attachment:image:<content-id>]`. This allows us to support specialist publisher inline image attachments and hopefully it can evolve to become the format other apps use for inline attachments.
Image attachments can be embedded inside HTML block level elements to different degrees of validity eg inside a <p> that's invalid whereas inside a <td> it's valid. However the way kramdown handles these scenarios is not desirable in either instance. It will convert the block level HTML elements into their HTML entity equivalent - thus an end user would see <div class="img"> on their screen. The way I've fixed this isn't pretty, we try output the image in a single line - which resolves some issues - and then we try convert back elements we expect to have been converted back to HTML.
danielroseman
approved these changes
Sep 30, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides supports for a markdown tag of
[embed:attachments:image:<content_id>]which allows attachments to be embedded as images.This is primarily to support the use of attached images in specialist publisher, however this does use the same HTML markup as the previous method to attach images
!!xso it brings these similar features closer together.A problem we encountered was the presence of block HTML elements within the image markup. This can cause Kramdown to (un)helpfully escaping the HTML elements to
<div>if image is placed within a block level element. To counter this I've put together a pretty ugly regex based fix.Also in this PR I've got a couple of dependency updates and minor fixes.