Update rubocop-govuk requirement from = 4.12.0 to = 4.13.0 #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Updates the requirements on [rubocop-govuk](https://github.com/alphagov/rubocop-govuk) to permit the latest version. - [Changelog](https://github.com/alphagov/rubocop-govuk/blob/main/CHANGELOG.md) - [Commits](alphagov/rubocop-govuk@v4.12.0...v4.13.0) --- updated-dependencies: - dependency-name: rubocop-govuk dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
|
This repo is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs. WhatWhyVisual Changes |
JonathanHallam
approved these changes
Dec 22, 2023
JonathanHallam
force-pushed
the
dependabot/bundler/rubocop-govuk-eq-4.13.0
branch
2 times, most recently
from
e2e21ba to
286de12
Compare
|
this is failing on a test because a method rubocop told me to use doesn't exist, don't have time to investigate, sorry! |
We have a false positive here from the unsafe Style/HashEachMethods cop. Rubocop thinks that we are calling `each` on a hash, but we are actually calling it on an array of two-element arrays. By putting parentheses around the block arguments we can indicate that we're not working with a hash, and suppress RuboCop offenses. See https://docs.rubocop.org/rubocop/cops_style.html#stylehasheachmethods
jkempster34
force-pushed
the
dependabot/bundler/rubocop-govuk-eq-4.13.0
branch
from
286de12 to
fe89a6a
Compare
jkempster34
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the requirements on rubocop-govuk to permit the latest version.
Changelog
Sourced from rubocop-govuk's changelog.
... (truncated)
Commits
51e44aeMerge pull request #338 from alphagov/bump-version2bf3ab8Bump to 4.13.052de757Merge pull request #337 from alphagov/dependabot/bundler/rubocop-rails-eq-2.23.096b74afUpdate rubocop-rails requirement from = 2.22.2 to = 2.23.049bf3f3Merge pull request #336 from alphagov/dependabot/bundler/rubocop-eq-1.59.0210aac4Update rubocop requirement from = 1.58.0 to = 1.59.0bdfbeefMerge pull request #335 from alphagov/dependabot/bundler/rubocop-eq-1.58.03e7dd46Update rubocop requirement from = 1.57.2 to = 1.58.0c9cf9eeMerge pull request #334 from alphagov/add-sca-sast-scansad93f12Add CodeQL (SAST) scan and Dependency Review (SCA) scan to CI pipelineDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)