Add LinkExtractor class #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camillavk
force-pushed
the
add_link_extractor
branch
from
63c42e8 to
4a449a2
Compare
thomasleese
reviewed
Jan 4, 2018
lib/govspeak/link_extractor.rb
Outdated
| private | ||
|
|
||
| def extract_links | ||
| processed_govspeak.css('a:not([href^="mailto"])').css('a:not([href^="#"])').map { |link| link['href'] } |
There was a problem hiding this comment.
I would maybe extract this line out to another method so it's something like:
def extract_links
document_anchors.map { |link| link['href'] }
end
def document_anchors
processed_govspeak.css('a:not([href^="mailto"])').css('a:not([href^="#"])')
end
camillavk
force-pushed
the
add_link_extractor
branch
from
4a449a2 to
491f121
Compare
thomasleese
approved these changes
Jan 4, 2018
Merged
thomasleese
suggested changes
Jan 4, 2018
This LinkExtractor class is used in several different publishing applications when checking links on documents
camillavk
force-pushed
the
add_link_extractor
branch
from
491f121 to
d1b0793
Compare
|
@thomasleese I've updated the CHANGELOG :) |
thomasleese
approved these changes
Jan 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This LinkExtractor class is used in several different publishing applications when checking links on documents. It extracts any links on the document, excluding ones starting with 'mailto:' or '#', and returns an array of the links present.