Fix buttons rendering incorrectly in linebreaks #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When testing with govspeak-preview I found buttons did not render as expected when using the preview mode, even though they render fine when pulled in as a markdown file. This ensures that these edge cases are considered and includes a test http://rubular.com/r/t7k2i3iwRd
NickColley
force-pushed
the
fix-button-linebreak-rendering
branch
from
e7c2890 to
d495c4e
Compare
|
I'm going to try and test this on publisher integration... |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing with govspeak-preview I found buttons did not render as expected when using the preview mode,
even though they render fine when pulled in as a markdown file.
This ensures that these edge cases are considered and includes a test.
http://rubular.com/r/t7k2i3iwRd
https://trello.com/c/ppqXaGPk/122-create-a-govspeak-component-for-buttons