Convert regex matches to equals #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasleese
approved these changes
May 3, 2017
|
just a quick one on the description for the PR.... "match method on string to be use of the equality operator." |
|
ha whoops I'll sort that |
kevindew
force-pushed
the
fix-regex-bug
branch
2 times, most recently
from
23d29b2 to
dfbddf6
Compare
This changes how we check whether a content_id matches for link/contacts/attachments. As the content_id is user input it should not be treated as a regex, so the equality operator is used instead. This shouldn't break any existing usages as nothing should have been reliant on regexs. This is to fix an error that was occurring of: "premature end of char-class: /1-1992 G-BJRT[2/"
|
Any chance a failing test/test could be added to demonstrate the issue with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the usage of match method on string to be use of the
equality operator. As the contents is user input it should not be
treated as a regex and there shouldn't be scenarios where a previous
match is no longer a match.
This is to fix an error that was occurring of: "premature end of
char-class: /1-1992 G-BJRT[2/"