This repository has been archived by the owner on Apr 11, 2024. It is now read-only.
Tweak "is this a substantial change?" heuristic #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Don't consider changes to the gemspec (because these are often just changes to dev dependencies) * Consider changes to the changelog (if a dev considers them important enough to include in the changelog then they're probably important enough to release)
This is a heuristic to decide if the changes since the previous version are significant enough to nag the owners of the repo to cut a new release, so let's introduce `change_is_significant?` to clarify this.
AgaDufrat
approved these changes
Mar 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're currently nagging devs too much (3 of the 5 repos this bot is notifying us about don't have changes substantial enough to bother releasing). Let's tweak the heuristic we use to decide if a change is important enough to nag about: