Add an alternative csv preview route #4445
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow us to experiment with a new way of doing CSV previews, avoiding the baggage of preview_url and the assets.publishing.service.gov.uk domain. This will need to be added as a prefix route in router before it will actually work.
catalinailie
force-pushed
the
new-csv-preview-urls
branch
from
c572701 to
7b86732
Compare
catalinailie
force-pushed
the
new-csv-preview-urls
branch
2 times, most recently
from
ebe6e8f to
d2c72a4
Compare
catalinailie
force-pushed
the
new-csv-preview-urls
branch
from
d2c72a4 to
43dfa6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to experiment with a new way of doing CSV previews, avoiding the baggage of preview_url and the
assets.publishing.service.gov.uk domain.
This will need to be added as a prefix route in router before it will actually work.