Take part document #4218
Open
Take part document #4218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KludgeKML
force-pushed
the
take-part-document
branch
from
6e82d3c
to
50b3e7b
Compare
KludgeKML
force-pushed
the
take-part-document
branch
from
50b3e7b
to
eccf200
Compare
KludgeKML
force-pushed
the
take-part-document
branch
from
eccf200
to
b39bc88
Compare
KludgeKML
force-pushed
the
take-part-document
branch
from
d765c5d
to
615613e
Compare
KludgeKML
force-pushed
the
take-part-document
branch
from
474bc41
to
f388c5c
Compare
KludgeKML
force-pushed
the
take-part-document
branch
from
f388c5c
to
3e8798f
Compare
KludgeKML
force-pushed
the
take-part-document
branch
from
3e8798f
to
c8466a7
Compare
KludgeKML
force-pushed
the
take-part-document
branch
from
88fb1fe
to
be0642f
Compare
KludgeKML
force-pushed
the
take-part-document
branch
from
04da7e5
to
7e70eea
Compare
KludgeKML
force-pushed
the
take-part-document
branch
from
7e70eea
to
1fcb485
Compare
KludgeKML
force-pushed
the
take-part-document
branch
from
1fcb485
to
a69ecfd
Compare
leenagupte
reviewed
Sep 10, 2024
config/locales/cy.yml
Outdated
| @@ -102,6 +102,15 @@ cy: | |||
| components: | |||
| figure: | |||
| image_credit: 'Delwedd gan: %{credit}' | |||
| content_item: | |||
| schema_name: | |||
| take_part: | |||
There was a problem hiding this comment.
There's also a formats lower this file that contains content for the original frontend document types.
I think they should all be in the same place, wherever that is.
KludgeKML
force-pushed
the
take-part-document
branch
from
a69ecfd
to
d84c600
Compare
KludgeKML
force-pushed
the
take-part-document
branch
from
d84c600
to
7b7fb17
Compare
KludgeKML
force-pushed
the
take-part-document
branch
from
7b7fb17
to
137a028
Compare
KludgeKML
force-pushed
the
take-part-document
branch
from
137a028
to
9f9c8de
Compare
- Used in Take Part, among others - Has Welsh and English translations - Includes spec file, documentation Commit audit trail: - app/assets/stylesheets/components/_figure.scss alphagov/government-frontend@10399a3 - app/views/components/_figure.html.erb alphagov/government-frontend@fe98d1d - app/views/components/docs/figure.yml alphagov/government-frontend@fe98d1d - en.yml/cy.yml alphagov/government-frontend@450b53a - spec/components/figure_spec.rb alphagov/government-frontend@fe98d1d
- Add code in ContentItem links into the desired internal format for the sidebar. Commit audit trail: - app/views/shared/_footer_navigation.html.erb alphagov/government-frontend@6500698 - app/views/shared/_sidebar_navigation.html.erb alphagov/government-frontend@abd4912
- Add helper to provide language names and translate content info into component format - Add methods to ContentItem to provide available translations Commit audit trail: - app/helpers/locale_helper.rb alphagov/government-frontend@90f0dd8 https://github.com/alphagov/government-frontend/blame/517e4d4619595806bc9a1fb904b2badb65332eaf/app/helpers/application_helper.rb - app/views/shared/_translations.html.erb alphagov/government-frontend@887399c - en.yml/cy.yml alphagov/government-frontend@665e1c1
KludgeKML
force-pushed
the
take-part-document
branch
from
75f4a0c
to
0d090a0
Compare
- add view and helpers - convert test suite to RSpec on move - add take_part translation keys used in title_helper to formats section in localisation files (in government-frontend this was in content_item.schema_name.*) - note that we explicitly remove the content-bottom-margin div class that was immediately inside the 2/3rds column. This is a style used in a handful of government-frontend document types which (on review with frontend developers) does not really fix the problem it's trying to fix (insufficient bottom margin on some tablet-sized devices). This has been captured as alphagov/govuk_publishing_components#4220 to be fixed properly in the components gem. Commit audit trail: - app/views/take_part/show.html.erb alphagov/government-frontend@e858440 - app/helpers/machine_readable_metadata_helper.rb alphagov/government-frontend@5fb924e - app/helpers/title_helper.rb alphagov/government-frontend@08db76d - spec/system/take_part_spec.rb alphagov/government-frontend@6ecd50c
KludgeKML
force-pushed
the
take-part-document
branch
from
352a8a3
to
a4f7b2a
Compare
commit audit trail: alphagov/government-frontend@76e9bd2#diff-6048e9f535fbd535b1c38ab5e387e5c6e0a485d411e9edbbbce9b111b40c25b7 (We have not copied the no-image tags yet, as they are not relevant for the take_part document type. We will bring in when a document type without images is ported over)
KludgeKML
force-pushed
the
take-part-document
branch
from
a4f7b2a
to
590d264
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Handle Take Part documents in Frontend, in preparation for them being taken out of Government Frontend
Why
https://trello.com/c/0LYU5bSd/318-move-route-document-type-takepart-from-governmentfrontend-to-frontend
How
These documents all have a fixed prefix, so add a scoped route for them, a controller, a model and a view. Here we add the initial ContentItem model the document type models will be based on, with the minimum functionality required to get Take Part documents working.
We also port across the figure component, which is used in this document type.
We also create a couple of helpers for rendering generic content.
Screenshots?
From example page: https://www.gov.uk/government/get-involved/take-part/improve-your-social-housing
Before (running in Government Frontend)
After (running in Frontend)