Fix add group member #241
Merged
Fix add group member #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting the form action using the button `formaction` attribute meant that the POST rule on the router was not being invoked.
Update test email address when adding a new group member to match email domain of other users in group.
christophercameron-ixd
temporarily deployed
to
forms-prototypes-pr-241
christophercameron-ixd
approved these changes
Mar 28, 2024
|
Omg thank you <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the "Add an editor to this group" route so that error messages work as expected.
Setting the form action using the button
formactionattribute meant that thePOSTrule on the router was not being called. This PR fixes things by removing that attribute. We also tweak the route to redirect to the same place as the button was, and some of the email addresses.