Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2023 12 15 update frontend #209

Merged
merged 8 commits into from
Jan 17, 2024
Merged

2023 12 15 update frontend #209

merged 8 commits into from
Jan 17, 2024

Conversation

christophercameron-ixd
Copy link
Contributor

@christophercameron-ixd christophercameron-ixd commented Dec 19, 2023 •
edited
Loading

Preview

https://forms-prototypes-pr-209.herokuapp.com/

What

  • Updated packages to use new version 5 of the frontend
  • Fixed URL issues off the back of the update
  • Updated task list to use the nunjucks
  • Updated tags to new colours and text

Other bits

  • Fixed incorrect heading classes being used
  • Added delete draft form functionality

Why

  • for future rounds of testing it makes sense to stay closely aligned with the development environment which has recently gone through the frontend update
  • it will help design continue to communicate effectively with developers when updating to new patterns

@christophercameron-ixd christophercameron-ixd temporarily deployed to forms-prototypes-pr-209 December 19, 2023 09:02 Inactive
@christophercameron-ixd christophercameron-ixd requested review from a team December 19, 2023 09:09
@christophercameron-ixd christophercameron-ixd added the chore Dependency updates etc. label Dec 19, 2023
jamie-o-wilkinson
jamie-o-wilkinson approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@jamie-o-wilkinson jamie-o-wilkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the caveat that I'm not that familiar with this repo, these changes look ok to me 😄

@christophercameron-ixd christophercameron-ixd merged commit 6a229b5 into main Jan 17, 2024
1 check passed
@christophercameron-ixd christophercameron-ixd deleted the 2023-12-15-update-frontend branch January 17, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamie-o-wilkinson jamie-o-wilkinson jamie-o-wilkinson approved these changes

Assignees

@christophercameron-ixd christophercameron-ixd

Labels
chore Dependency updates etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christophercameron-ixd @jamie-o-wilkinson