Enable users to signup to all content by organisation #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 11, 2019 12:06
This is a refactor, it wont change things for end users. The intent is to make it easier to add estimates for other content items in the future. In a commit to follow I will make it possible to estimate the weekly email volume for people and so on.
This replaces the TaxonomySignup model with a new model, ContentItemSubscriberList. End users wont see a change as a result of this commit. The intent is to make it possible to give an arbitrary content item to the ContentItemSubscriberList and have it return a subscriber list for that content item. TaxonomySignup does this just for taxons. Now we can use ContentItemSubscriberList to generate subscriber lists for people, organisations, and so on. In a future commit I will use this class to generate subscriber lists for organisations.
This lets one use /email-signup?link=/path-to-content-item to subscribe to permitted content items, rather than subscribing just to e.g. ?topic=/education. As with the past couple of commits, this is just a minor refactor, moving things around, generalising taxon to content_item. End users wont see a change as result of this commit. In a following commit I will make it possible to subscribe to organisations via this endpoint.
This will enable users to subscribe to organisations content items via the /email-signup?link=ministry-of-magic endpoint. It will behave in the same way as the topic signup does currently. Trello: https://trello.com/c/KsDrrchK/620.
bilbof
changed the title
bilbof
pushed a commit
to alphagov/collections
that referenced
this pull request
Apr 12, 2019
This will enable users to subscribe to organisation email alerts via the EmailAlertFrontend user interface. **Note:** Should be merged after alphagov/email-alert-frontend#451 Trello: https://trello.com/c/NSJuSR4z/587.
barrucadu
reviewed
Apr 16, 2019
| class OrganisationWeeklyEmailVolume | ||
| HIGH = '40 - 60'.freeze | ||
| MEDIUM = '0 - 20'.freeze | ||
| LOW = '0 - 5'.freeze |
There was a problem hiding this comment.
Are these numbers based on anything?
There was a problem hiding this comment.
It's very much a finger-in-air estimate. This is the same as our estimates for taxonomy emails (which may now be wrong).
This is the explanation in the commit (d4a97b2#diff-5c90fde72d5dd7ed3acd972c5bc07f58) where the taxonomy estimate was added:
These figures are based on analysis of historical email volume.
Perhaps we could make a request to email-alert-api to figure out the exact volume.
barrucadu
suggested changes
Apr 16, 2019
barrucadu
approved these changes
Apr 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will enable users to subscribe to organisations content items via the /email-signup?link=ministry-of-magic endpoint.
It will behave in the same way as the taxonomy signup does currently.
Most of the changes are related to generalising the existing taxonomy endpoint to support all links, not just taxons.
I refactored the taxonomy code and then added in the organisations logic. It'll be easiest to review commit by commit.
Trello: https://trello.com/c/KsDrrchK/620.
Go to https://finder-frontend-pr-X.herokuapp.com/email-signup?link=hm-treasury to try it out.
Views: