Fix/checkpoint verification in CL STF #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #730 +/- ##
==========================================
- Coverage 54.90% 54.79% -0.11%
==========================================
Files 321 322 +1
Lines 35826 35961 +135
==========================================
+ Hits 19669 19704 +35
- Misses 16157 16257 +100
... and 21 files with indirect coverage changes 🚀 New features to boost your workflow:
|
prajwolrg
changed the title
|
Commit: d6a005e SP1 Execution Results
|
bewakes
approved these changes
Mar 12, 2025
MdTeach
approved these changes
Mar 13, 2025
sapinb
approved these changes
Mar 13, 2025
storopoli
approved these changes
Mar 13, 2025
delbonis
reviewed
Mar 13, 2025
Comment on lines
+202
to
+213
| if receipt.proof().is_empty() { | ||
| warn!(%ckpt_epoch, "Empty proof posted"); | ||
| // If the proof is empty but empty proofs are not allowed, this will fail. | ||
| if !params.proof_publish_mode.allow_empty() { | ||
| error!(%ckpt_epoch, "Invalid checkpoint: Empty proof"); | ||
| return Err(TsnError::InvalidProof); | ||
| } | ||
| } else { | ||
| // Otherwise, verify the non-empty proof. | ||
| verify_rollup_groth16_proof_receipt(&receipt, ¶ms.rollup_vk) | ||
| .map_err(|e| TsnError::InvalidProof)?; | ||
| } |
There was a problem hiding this comment.
I just realized that this returning an error means if a sequencer publishes an invalid checkpoint then we can never produce a new block after we receive it (without rolling back L1), since this will always fail the state transition. We should just disregard it (and print an error/warning).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Notes to Reviewers
Checklist
Related Issues