Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors #40

Merged
merged 2 commits into from
Mar 7, 2025
Merged

Refactors #40

merged 2 commits into from
Mar 7, 2025

Conversation

storopoli
Copy link
Member

@storopoli storopoli commented Mar 7, 2025

Description

  • Makes P2PHandle able to sign messages
  • Renames OperatorPubKey to P2POperatorPubKey.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

Needed for better ergonomics in the strata-bridge repo.

cargo-audit is broken I tried to fix it later but it is not that trivial.
We might need to drop the rust nightly version and go to 1.85 stable to fix this.

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
storopoli Jose Storopoli
@storopoli storopoli requested a review from Rajil1213 March 7, 2025 17:28
Copy link
Contributor

github-actions bot commented Mar 7, 2025

The latest Buf updates on your PR. Results from workflow Lint / proto (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedMar 7, 2025, 5:30 PM

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 45.23810% with 23 lines in your changes missing coverage. Please review.

Project coverage is 85.06%. Comparing base (c0c07fa) to head (ed40f0c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/p2p/src/swarm/handle.rs 40.00% 15 Missing ⚠️
crates/p2p/src/swarm/mod.rs 37.50% 5 Missing ⚠️
crates/p2p/src/commands.rs 33.33% 2 Missing ⚠️
crates/db/src/lib.rs 66.66% 1 Missing ⚠️
@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
- Coverage   85.36%   85.06%   -0.31%     
==========================================
  Files          16       16              
  Lines        1715     1734      +19     
==========================================
+ Hits         1464     1475      +11     
- Misses        251      259       +8     
Files with missing lines Coverage Δ
crates/db/src/sled.rs 78.00% <100.00%> (ø)
crates/types/src/operator.rs 80.00% <100.00%> (ø)
crates/wire/src/p2p/v1/typed.rs 90.20% <100.00%> (ø)
crates/db/src/lib.rs 82.29% <66.66%> (ø)
crates/p2p/src/commands.rs 80.89% <33.33%> (ø)
crates/p2p/src/swarm/mod.rs 80.63% <37.50%> (-0.62%) ⬇️
crates/p2p/src/swarm/handle.rs 46.51% <40.00%> (+7.80%) ⬆️
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Verified

This commit was signed with the committer’s verified signature.
storopoli Jose Storopoli
Copy link
Collaborator

@Rajil1213 Rajil1213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was quick!

So the keypair wasn't even being used in the P2PHandle?

The P2P comments are redundant now but that's fine.

@storopoli storopoli added this pull request to the merge queue Mar 7, 2025
Merged via the queue into main with commit c5d0f60 Mar 7, 2025
13 of 15 checks passed
@storopoli storopoli deleted the refactors branch March 7, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants