Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional asof for historical marketdata endpoints #632

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Add optional asof for historical marketdata endpoints #632

merged 1 commit into from
Jun 23, 2022

Conversation

gnvk
Copy link
Contributor

@gnvk gnvk commented Jun 23, 2022

No description provided.

@gnvk gnvk requested a review from haxdds as a code owner June 23, 2022 04:08
Copy link
Contributor

@noramehesz noramehesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@gnvk gnvk merged commit 8077685 into master Jun 23, 2022
@gnvk gnvk deleted the asof branch June 23, 2022 10:17
@benlevitas
Copy link

It would be nice if asof also supported different adjusted prices. Meaning that if we were to look back a year at adjusted prices with no asof we might get a price that has been adjusted 4 times, while looking back a year with an asof that was 9 months ago we will get a price that has been adjusted once.

@sshcli
Copy link

sshcli commented Sep 20, 2022

It would be nice if asof also supported different adjusted prices.

@benlevitas I think you should create a feature request in the new official repo:
https://github.com/alpacahq/alpaca-py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants