Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding a previously unmapped activity type #765

Merged
merged 2 commits into from
Nov 10, 2024
Merged

adding a previously unmapped activity type #765

merged 2 commits into from
Nov 10, 2024

Conversation

Chacoon3
Copy link
Contributor

@Chacoon3 Chacoon3 commented Nov 5, 2024 •
edited
Loading

Pull Request Template

Use this template to quickly create a well written pull request. Delete all quotes before creating the pull request.

Description

The only change made was to add a previously unmapped activity type, "Option Trade". Its string value returned from the REST endpoint is OPTRD.

Fixes # (issue)

This can ensure the JSON parser works properly when dealing with account activities of Option Trade.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

I have not conducted any test yet as I got problems running the test cases in my local environment.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@Chacoon3 Chacoon3 mentioned this pull request Nov 5, 2024
Closed
1 task
@OlegRa OlegRa self-assigned this Nov 10, 2024
@OlegRa OlegRa added the bug Something isn't working label Nov 10, 2024
@OlegRa OlegRa linked an issue Nov 10, 2024 that may be closed by this pull request
[BUG]: Unmapped AccountActivityType Leading to SDK Error #764
Closed
1 task
@OlegRa OlegRa added this to the SDK 7.x LTS milestone Nov 10, 2024
@OlegRa OlegRa merged commit 30af5fd into alpacahq:develop Nov 10, 2024
3 checks passed
OlegRa pushed a commit that referenced this pull request Nov 10, 2024
@Chacoon3 @OlegRa
adding a previously unmapped activity type (#765)
f6bde3f 
* adding a previously unmapped activity type

* Fixed compilation issues before merging changes to the origin repository.

---------

Co-authored-by: Oleg Rakhmatulin <oleg.rakhmatulin@gmail.com>
(cherry picked from commit 30af5fd)
@OlegRa OlegRa self-requested a review November 10, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlegRa OlegRa Awaiting requested review from OlegRa

Assignees

@OlegRa OlegRa

Labels
bug Something isn't working
Projects
None yet
Milestone
SDK 7.x LTS
Development

Successfully merging this pull request may close these issues.

[BUG]: Unmapped AccountActivityType Leading to SDK Error
2 participants
@Chacoon3 @OlegRa