Prepare release 7.1.0-beta3 of Extensions

alpacahq · Apr 28, 2024 · c3b469a · c3b469a
1 parent 476e681
commit c3b469a
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 9 deletions.
diff --git a/Alpaca.Markets.Extensions.Tests/AlpacaTradingClientTest.cs b/Alpaca.Markets.Extensions.Tests/AlpacaTradingClientTest.cs
@@ -1,6 +1,9 @@
+using System.Diagnostics.CodeAnalysis;
+
 namespace Alpaca.Markets.Extensions.Tests;
 
 [Collection("MockEnvironment")]
+[SuppressMessage("Usage", "xUnit1047:Avoid using TheoryDataRow arguments that might not be serializable")]
 public sealed class AlpacaTradingClientTest(
     MockClientsFactoryFixture mockClientsFactory)
 {

diff --git a/Alpaca.Markets.Extensions/Alpaca.Markets.Extensions.csproj b/Alpaca.Markets.Extensions/Alpaca.Markets.Extensions.csproj
@@ -12,14 +12,14 @@
   </PropertyGroup>
 
   <PropertyGroup>
-    <AssemblyVersion>7.1.0.1</AssemblyVersion>
-    <FileVersion>7.1.0.1</FileVersion>
-    <Version>7.1.0-beta2</Version>
+    <AssemblyVersion>7.1.0.2</AssemblyVersion>
+    <FileVersion>7.1.0.2</FileVersion>
+    <Version>7.1.0-beta3</Version>
   </PropertyGroup>
 
   <PropertyGroup>
     <PackageReleaseNotes>
-- The `ListOptionContractsAsAsyncEnumerable` extensions method uses page token now.
+- Added new methods `GetOptionChainAsyncAsAsyncEnumerable` and `ListSnapshotsAsAsyncEnumerable` into the Extensions package.
     </PackageReleaseNotes>
     <Description>C# SDK for Alpaca Trade API https://docs.alpaca.markets/</Description>
     <RepositoryUrl>https://github.com/alpacahq/alpaca-trade-api-csharp</RepositoryUrl>

diff --git a/Alpaca.Markets.Extensions/Pagination/AlpacaOptionsDataClientExtensions.cs b/Alpaca.Markets.Extensions/Pagination/AlpacaOptionsDataClientExtensions.cs
@@ -140,7 +140,7 @@ private static OptionSnapshotRequest getRequestWithoutPageToken(
         OptionSnapshotRequest request) =>
         new(request.Symbols)
         {
-            //Pagination = { Size = Pagination.MaxPageSize },
+            Pagination = { Size = request.Pagination.Size },
             OptionsFeed = request.OptionsFeed
         };
 
@@ -172,7 +172,7 @@ private static OptionChainRequest getRequestWithoutPageToken(
             StrikePriceGreaterThanOrEqualTo = request.StrikePriceGreaterThanOrEqualTo,
             StrikePriceLessThanOrEqualTo = request.StrikePriceLessThanOrEqualTo,
             ExpirationDateEqualTo = request.ExpirationDateEqualTo,
-            Pagination = { Size = Pagination.MaxPageSize },
+            Pagination = { Size = request.Pagination.Size },
             OptionType = request.OptionType,
             RootSymbol = request.RootSymbol
         };

diff --git a/Alpaca.Markets.Extensions/Pagination/AlpacaTradingClientExtensions.cs b/Alpaca.Markets.Extensions/Pagination/AlpacaTradingClientExtensions.cs
@@ -179,7 +179,7 @@ private static OptionContractsRequest getRequestForFirstPage(
             StrikePriceGreaterThanOrEqualTo = request.StrikePriceGreaterThanOrEqualTo,
             StrikePriceLessThanOrEqualTo = request.StrikePriceLessThanOrEqualTo,
             ExpirationDateEqualTo = request.ExpirationDateEqualTo,
-            Pagination = { Size = Pagination.MaxPageSize },
+            Pagination = { Size = request.Pagination.Size },
             AssetStatus = request.AssetStatus,
             OptionStyle = request.OptionStyle,
             OptionType = request.OptionType,

diff --git a/Alpaca.Markets/Helpers/HttpClientExtensions.Get.cs b/Alpaca.Markets/Helpers/HttpClientExtensions.Get.cs
@@ -51,7 +51,7 @@ public static async Task<IReadOnlyDictionary<String, TValueApi>> GetAsync
                     uriBuilder, rateLimitHandler, cancellationToken)
                 .ConfigureAwait(false)), elementSelector, StringComparer.Ordinal);
 
-    private static IReadOnlyDictionary<TKeyApi, TValueApi> getReadOnlyDictionary<TKeyApi, TValueApi, TKeyJson, TValueJson>(
+    private static Dictionary<TKeyApi, TValueApi> getReadOnlyDictionary<TKeyApi, TValueApi, TKeyJson, TValueJson>(
         Dictionary<TKeyJson, TValueJson> response, 
         Func<KeyValuePair<TKeyJson, TValueJson>, TValueApi> elementSelector,
         IEqualityComparer<TKeyApi> comparer)

diff --git a/Alpaca.Markets/Messages/JsonOptionSnapshotsData.cs b/Alpaca.Markets/Messages/JsonOptionSnapshotsData.cs
@@ -8,7 +8,7 @@ internal sealed class JsonOptionsSnapshotData : IDictionaryPage<IOptionSnapshot>
 {
     [DebuggerBrowsable(DebuggerBrowsableState.Never)]
     [JsonProperty(PropertyName = "snapshots", Required = Required.Default)]
-    public Dictionary<String, JsonOptionSnapshot> ItemsList { get; [ExcludeFromCodeCoverage] set; } = new();
+    public Dictionary<String, JsonOptionSnapshot> ItemsList { get; [ExcludeFromCodeCoverage] set; } = [];
 
     [JsonProperty(PropertyName = "next_page_token", Required = Required.Default)]
     public String? NextPageToken { get; set; }