Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapted the rbootnoise tests into the context #32

Merged
merged 15 commits into from
Dec 7, 2023
Merged

Adapted the rbootnoise tests into the context #32

merged 15 commits into from
Dec 7, 2023

Commits on Oct 31, 2023

  1. Changed the identical() into all.equal() which allows insignificant 1… 

    ….5e-8 deviations, for example caused by expected rounding errors between different systems.
    @IlmariTamminen
    IlmariTamminen committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    a91da77 View commit details
    Browse the repository at this point in the history

  2. Try to activete the R CMD Check for the new branch

    @IlmariTamminen
    IlmariTamminen committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    d780233 View commit details
    Browse the repository at this point in the history

  3. In the other than all.equal() comparisons, tolerated larger deviation… 

    …s due to the unavoidable technical variation without carefully controlled containerized environment not applicable in the R CMD Checks.
    @IlmariTamminen
    IlmariTamminen committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    e6ca35e View commit details
    Browse the repository at this point in the history

  4. Further changes regarding the previous commit.

    @IlmariTamminen
    IlmariTamminen committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    887b6f1 View commit details
    Browse the repository at this point in the history

  5. Further modifications regarding the previous commits

    @IlmariTamminen
    IlmariTamminen committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    58db8db View commit details
    Browse the repository at this point in the history

  6. Removed the test that expected (obvious) FALSE when data w/wo rbnoise… 

    … were compared. This somewhat useless test caused absurd behaviour with the deviation tolerance of the all.equal() (different data gave TRUE). Also increased the remaining tolerances of other tests.
    @IlmariTamminen
    IlmariTamminen committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    2effc03 View commit details
    Browse the repository at this point in the history

  7. Further increased the limit of accepted variation. I suspect that som… 

    …ething major has changed in the background, such as how the set.seed() works. https://stackoverflow.com/questions/47199415/is-set-seed-consistent-over-different-versions-of-r-and-ubuntu
    @IlmariTamminen
    IlmariTamminen committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    15dfabb View commit details
    Browse the repository at this point in the history

  8. The final failing test is the one which cannot follow the set.seed() … 

    …exactly the same way. Its tolerance limit was increased further. The new principles of these tests were explained in the earlier commit.
    @IlmariTamminen
    IlmariTamminen committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    9763053 View commit details
    Browse the repository at this point in the history

  9. Further increased the limit of tolerance, the new principles of the t… 

    …ests explained in the earlier commit.
    @IlmariTamminen
    IlmariTamminen committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    7e3ba50 View commit details
    Browse the repository at this point in the history

  10. Further increased the limit of tolerance in the test that cannot foll… 

    …ow the set.seed() exactly
    @IlmariTamminen
    IlmariTamminen committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    08a8624 View commit details
    Browse the repository at this point in the history

  11. Earlier had problems with varying attributes that related to saving d… 

    …ata to hard drive and loading them back into memory. If these nominal differences are the reason, let's reject those. Thanks to excellent other tests of the lmeresampler, the carry-over of attributes within an R session should be okay.
    @IlmariTamminen
    IlmariTamminen committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    96c8344 View commit details
    Browse the repository at this point in the history

  12. The new all.equal() possibly had issues. The main purpose of these te… 

    …sts is to check the numeric reporducibility within the accepted deviation. The numeric-deviation limit decreased back to lower level and all.equal() removed.
    @IlmariTamminen
    IlmariTamminen committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    512b01c View commit details
    Browse the repository at this point in the history

  13. A few more tweaks of the comments. The new all.equal() was actually t… 

    …he problem, also in this context. It was removed and focus put on the acceptable numeric reproduction of the results considering the cross-platform non-containerized context.
    @IlmariTamminen
    IlmariTamminen committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    7d67c22 View commit details
    Browse the repository at this point in the history

  14. Removed the R CMD check of the tuning-tests branch

    @IlmariTamminen
    IlmariTamminen committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    487b34c View commit details
    Browse the repository at this point in the history

  15. Merge pull request #1 from IlmariTamminen/tuning-tests 

    Tuning tests
    @IlmariTamminen
    IlmariTamminen authored Oct 31, 2023
    Configuration menu
    Copy the full SHA
    b3198b8 View commit details
    Browse the repository at this point in the history